(Closes #913) move 'colored' util from psyir.nodes to psyclone.utils - #3578
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3578 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 399 399
Lines 56467 56482 +15
=========================================
+ Hits 56467 56482 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
arporter
requested changes
Sep 4, 2026
arporter
left a comment
arporter
left a comment
Member
There was a problem hiding this comment.
Good job @haanahfrost. Just a bit of tidying and modernising to do. (Note I've brought the branch up to master so you'll need to do a pull before making further changes.)
Member
|
Linkspector failure is just due to Zenodo being very slow - it gets there in the end. |
arporter
approved these changes
Sep 10, 2026
arporter
left a comment
arporter
left a comment
Member
There was a problem hiding this comment.
ITs were all green.
I'll proceed to merge.
Member
|
The linkspector and doc-build failures are all due to Zenodo still being slow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the 'colored' utility out of
psyir/nodes/nodes.pyintopsyclone/utils.pypsyir/nodes/node.py: removed the definition and the#913TODO; now importscoloredfrompsyclone.utilsfor its single call site incoloured_name(). Removed from__all__.psyir/nodes/__init__.py: removed the re-export and the__all__entry